Resolve errors page fix #1439
Open
Resolve errors page fix #1439
+49
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-by: fellipepcs <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rubocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
wwahammy
requested changes
Dec 14, 2022
There was a problem hiding this comment.
@DafneM and @fellipepcs thank you so much for the contribution. I particularly appreciate the initiative you took to realize that we should use exceptions_app. This is a really great start.
I've made a number of comments on necessary improvements before merging; most of them are minor. I look forward to your future changes. Please re-request my review when you're ready.
Thanks so much again.
|
Made changes to requests requested above. |
|
Hey @wwahammy is there anything we can do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complement the issue: #3
Created by @DafneM and @fellipepcs